feat: add terminal review comments#1
Merged
Conversation
Member
Author
|
Implementation is complete and ready to merge.
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files and piped text now have a focused terminal review surface instead of requiring a browser or source edits.
Users can drag across line ranges, write and revisit inline comments, and emit only the quoted ranges by default.
The same review can also produce the full quoted document or a versioned JSON sidecar.
What Changed
The new Rust CLI keeps terminal interaction separate from source and output data.
It renders through
/dev/tty, so stdout remains safe for normal Unix pipelines.comments,full, andjsonoutput formats plus atomically saved JSON sidecars guarded by the exact source SHA-256.Testing
The complete local CI contract passes.
The tmux test drives the compiled binary through a pseudoterminal with real SGR mouse press, drag, and release events, then verifies default Markdown, full Markdown, JSON, and sidecar reload behavior.
scripts/ci-local.shcargo +1.88.0 check --workspace/dev/ttyadapters are exercised by the tmux process test.cargo auditfound no vulnerable dependencies.Risks
The first release deliberately targets Unix terminals and UTF-8 input.
Terminal emulators can differ in modified-Enter and mouse reporting, so Ctrl-O is the portable multiline shortcut and Crossterm button tracking is retained across drag events.
--no-mouseprovides a keyboard-only mode.