feat: add shift range commenting#2
Merged
Merged
Conversation
Member
Author
Final implementation reportThis change adds keyboard-driven range commenting while keeping the interface focused:
Verification
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keyboard users had to enter a separate selection mode before commenting on a range.
This change makes Shift-Up and Shift-Down extend a line range and opens the comment editor when Shift is released.
Saved range comments now keep a green rail beside every covered source line, so their full anchor remains visible.
What Changed
The keyboard and mouse flows now share the same range-selection model.
The terminal requests enhanced key events where supported and retains a next-key fallback for older terminals.
Testing
Unit, rendering, architecture, and real pseudoterminal interactions pass locally.
The complete mutation, coverage, audit, documentation, and compatibility gate is clean.
cargo test --workspace --all-targetscargo clippy --workspace --all-targets --all-features -- -D warningsscripts/e2e-tmux.shscripts/ci-local.shcargo +1.88.0 check --workspaceRisks
Modifier-release events depend on terminal keyboard-protocol support.
Compatible terminals open the editor immediately on Shift release; older terminals finalize the range on the first subsequent unshifted key and apply that key to the editor.
vselection mode remain available.