feat(build-macos-apps): add macOS app building skills and commands#72
Conversation
New plugin for building, debugging, instrumenting, and implementing macOS apps with SwiftUI and AppKit guidance, codesigning, packaging, and telemetry workflows. 11 skills (liquid-glass, signing-entitlements, packaging-notarization, test-triage, window-management, telemetry, swiftui-patterns, view-refactor, appkit-interop, build-run-debug, swiftpm-macos) + 3 commands (build-and-run-macos-app, fix-codesign-error, test-macos-app) + agent definition. Claude + Codex manifests included; already registered in the marketplace manifests. Co-Authored-By: duyetbot <duyetbot@users.noreply.github.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reached
More reviews will be available in 4 minutes and 8 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (30)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Welcome! 👋Thank you for your first contribution to this project! We appreciate you taking the time to improve our codebase. Next Steps
Contribution Guidelines
Thanks again for contributing! 🎉 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive suite of guides, commands, and manifests for a macOS development plugin, covering areas like AppKit interop, window management, and SwiftUI patterns. The review feedback highlights several critical issues in the reference code snippets: a layout issue with NSTextView resizability, a deprecation warning for NSApplication.activate(ignoringOtherApps:) on macOS 14+, a compilation error due to a missing position: label in WindowPlacement, a potential background process leak in the bootstrap shell script, and a design convention violation regarding .scenePadding() on a TabView.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| func makeNSView(context: Context) -> NSScrollView { | ||
| let scrollView = NSScrollView() | ||
| let textView = NSTextView() | ||
| textView.delegate = context.coordinator | ||
| scrollView.documentView = textView | ||
| return scrollView | ||
| } |
There was a problem hiding this comment.
Programmatically setting up an NSTextView inside an NSScrollView without configuring resizing masks and container tracking properties often leads to layout issues where the text view does not wrap text or fill the scroll view properly. It is highly recommended to configure the text view's vertical resizability, autoresizing mask, and text container width tracking.
| func makeNSView(context: Context) -> NSScrollView { | |
| let scrollView = NSScrollView() | |
| let textView = NSTextView() | |
| textView.delegate = context.coordinator | |
| scrollView.documentView = textView | |
| return scrollView | |
| } | |
| func makeNSView(context: Context) -> NSScrollView { | |
| let scrollView = NSScrollView() | |
| scrollView.hasVerticalScroller = true | |
| let textView = NSTextView() | |
| textView.isVerticallyResizable = true | |
| textView.autoresizingMask = [.width] | |
| textView.textContainer?.containerSize = NSSize(width: scrollView.contentSize.width, height: CGFloat.greatestMagnitude) | |
| textView.textContainer?.widthTracksTextView = true | |
| textView.delegate = context.coordinator | |
| scrollView.documentView = textView | |
| return scrollView | |
| } |
| final class AppDelegate: NSObject, NSApplicationDelegate { | ||
| func applicationDidFinishLaunching(_ notification: Notification) { | ||
| NSApp.setActivationPolicy(.regular) | ||
| NSApp.activate(ignoringOtherApps: true) | ||
| } | ||
| } |
There was a problem hiding this comment.
NSApplication.activate(ignoringOtherApps:) is deprecated starting in macOS 14.0. Since the minimum system version target is macOS 14.0, use the modern parameterless NSApplication.activate() instead to avoid deprecation warnings.
| final class AppDelegate: NSObject, NSApplicationDelegate { | |
| func applicationDidFinishLaunching(_ notification: Notification) { | |
| NSApp.setActivationPolicy(.regular) | |
| NSApp.activate(ignoringOtherApps: true) | |
| } | |
| } | |
| final class AppDelegate: NSObject, NSApplicationDelegate { | |
| func applicationDidFinishLaunching(_ notification: Notification) { | |
| NSApp.setActivationPolicy(.regular) | |
| NSApp.activate() | |
| } | |
| } |
| .windowIdealPlacement { content, context in | ||
| let idealSize = content.sizeThatFits(.unspecified) | ||
| let displayBounds = context.defaultDisplay.visibleRect | ||
| let zoomedSize = zoomToFit(idealSize, displayBounds: displayBounds) | ||
| let position = centeredPosition(for: zoomedSize, in: displayBounds) | ||
| return WindowPlacement(position, size: zoomedSize) | ||
| } |
There was a problem hiding this comment.
The WindowPlacement initializer requires the position: argument label. Omitting it will result in a compilation error.
| .windowIdealPlacement { content, context in | |
| let idealSize = content.sizeThatFits(.unspecified) | |
| let displayBounds = context.defaultDisplay.visibleRect | |
| let zoomedSize = zoomToFit(idealSize, displayBounds: displayBounds) | |
| let position = centeredPosition(for: zoomedSize, in: displayBounds) | |
| return WindowPlacement(position, size: zoomedSize) | |
| } | |
| .windowIdealPlacement { content, context in | |
| let idealSize = content.sizeThatFits(.unspecified) | |
| let displayBounds = context.defaultDisplay.visibleRect | |
| let zoomedSize = zoomToFit(idealSize, displayBounds: displayBounds) | |
| let position = centeredPosition(for: zoomedSize, in: displayBounds) | |
| return WindowPlacement(position: position, size: zoomedSize) | |
| } |
| --logs|logs) | ||
| "$APP_BINARY" & | ||
| /usr/bin/log stream --info --style compact --predicate "process == \"$APP_NAME\"" | ||
| ;; | ||
| --telemetry|telemetry) | ||
| "$APP_BINARY" & | ||
| /usr/bin/log stream --info --style compact --predicate "subsystem == \"com.example.MyTool\"" | ||
| ;; |
There was a problem hiding this comment.
Running the CLI binary in the background (&) and then starting a foreground log stream will leave the background process running indefinitely when the user terminates the script (e.g., via Ctrl+C). To prevent process leaks, use a trap to clean up the background process on script exit.
| --logs|logs) | |
| "$APP_BINARY" & | |
| /usr/bin/log stream --info --style compact --predicate "process == \"$APP_NAME\"" | |
| ;; | |
| --telemetry|telemetry) | |
| "$APP_BINARY" & | |
| /usr/bin/log stream --info --style compact --predicate "subsystem == \"com.example.MyTool\"" | |
| ;; | |
| --logs|logs) | |
| "$APP_BINARY" & | |
| PID=$! | |
| trap 'kill "$PID" 2>/dev/null || true' EXIT | |
| /usr/bin/log stream --info --style compact --predicate "process == \"$APP_NAME\"" | |
| ;; | |
| --telemetry|telemetry) | |
| "$APP_BINARY" & | |
| PID=$! | |
| trap 'kill "$PID" 2>/dev/null || true' EXIT | |
| /usr/bin/log stream --info --style compact --predicate "subsystem == \"com.example.MyTool\"" | |
| ;; |
| var body: some View { | ||
| TabView { | ||
| Form { | ||
| Toggle("Show Sidebar Icons", isOn: $showSidebarIcons) | ||
| } | ||
| .tabItem { Label("General", systemImage: "gearshape") } | ||
| } | ||
| .frame(width: 460, height: 260) | ||
| .scenePadding() | ||
| } |
There was a problem hiding this comment.
Applying .scenePadding() to the TabView itself will pad the tab bar/header, which violates macOS design conventions and pushes the tab items away from the window edges. Instead, apply padding to the content inside the tab items (e.g., on the Form).
| var body: some View { | |
| TabView { | |
| Form { | |
| Toggle("Show Sidebar Icons", isOn: $showSidebarIcons) | |
| } | |
| .tabItem { Label("General", systemImage: "gearshape") } | |
| } | |
| .frame(width: 460, height: 260) | |
| .scenePadding() | |
| } | |
| var body: some View { | |
| TabView { | |
| Form { | |
| Toggle("Show Sidebar Icons", isOn: $showSidebarIcons) | |
| } | |
| .padding() | |
| .tabItem { Label("General", systemImage: "gearshape") } | |
| } | |
| .frame(width: 460, height: 260) | |
| } |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6aea5f91d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| rm -rf "$APP_BUNDLE" | ||
| mkdir -p "$APP_MACOS" | ||
| cp "$BUILD_BINARY" "$APP_BINARY" |
There was a problem hiding this comment.
When this template is used for a SwiftPM GUI app that declares resources, copying only the executable into Contents/MacOS drops SwiftPM's generated resource bundles (Bundle.module assets, localizations, etc.). The resulting .app can build and launch but then fail to load assets or crash on resource lookups, so the bootstrap script should also stage the product's resource bundles into Contents/Resources.
Useful? React with 👍 / 👎.
| "capabilities": [ | ||
| "Skill", | ||
| "Command", | ||
| "Agent" |
There was a problem hiding this comment.
This manifest advertises an Agent, but the new plugin only adds agents/openai.yaml; the repo convention and docs tooling consume agent definitions as agents/*.md with YAML frontmatter, so installing/generating docs for this plugin exposes an Agent capability with no discoverable sub-agent. Either add a real .md agent definition or remove the agents entry and Agent capability until one exists.
Useful? React with 👍 / 👎.
| 3. Run the right product. | ||
| - Use `swift run <product>` when an executable exists. | ||
| - If multiple executables exist, explain the default choice. |
There was a problem hiding this comment.
When the SwiftPM product is a SwiftUI/AppKit GUI executable, swift run <product> launches the raw binary instead of the .app bundle that the rest of this plugin says is required for Dock activation and bundle metadata. This skill is the package-first entry point, so it should either detect GUI products and delegate to the bundle-building build-run-debug flow or explicitly limit swift run to true CLI tools.
Useful? React with 👍 / 👎.
| --debug|debug) | ||
| lldb -- "$APP_BINARY" |
There was a problem hiding this comment.
For SwiftPM GUI apps, --debug runs lldb against the raw executable inside Contents/MacOS instead of launching the .app bundle and attaching to that process. Any issue that depends on bundle metadata, resources, activation policy, or entitlements will be debugged in a different environment than the normal run path, so this mode can mask or misdiagnose launch-only failures.
Useful? React with 👍 / 👎.
| icon_small: "./assets/build-macos-apps-small.svg" | ||
| icon_large: "./assets/app-icon.png" |
There was a problem hiding this comment.
This metadata points at two plugin-local icon files, but the commit does not add an assets/ directory or either referenced file. Any surface that reads this metadata will show broken icons or fail asset resolution for the new plugin, so either include the assets or remove these references until they exist.
Useful? React with 👍 / 👎.
- Tag directory-tree fences as text (MD040) - Wrap three guideline lines over 400 chars (MD013) - Collapse codex capabilities array (JSON_PRETTIER) - Apply prettier formatting to 7 SKILL.md files (MARKDOWN_PRETTIER) Co-Authored-By: duyetbot <duyetbot@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 participants
Adds the
build-macos-appsplugin for building, debugging, instrumenting, and implementing macOS apps with SwiftUI and AppKit guidance, codesigning, packaging, and telemetry.Skills (11): liquid-glass, signing-entitlements, packaging-notarization, test-triage, window-management, telemetry, swiftui-patterns, view-refactor, appkit-interop, build-run-debug, swiftpm-macos.
Commands (3): build-and-run-macos-app, fix-codesign-error, test-macos-app.
Includes Claude + Codex manifests and an agent definition. The plugin is already registered in the marketplace manifests; this adds the missing plugin files.