Remove rspec-collection_matchers dependency.#36
Conversation
This does not really really add to readability while one less dependency is beneficial.
| json = '{"json_class":"CookieJar::Jar","cookies":[{"name":"foo","value":"bar","domain":"localhost.local","path":"\\/","created_at":"2009-09-11 12:51:03 -0600","expiry":"2028-11-01 12:00:00 GMT","secure":true}]}' | ||
| jar = JSON.parse json, create_additions: true | ||
| expect(jar.get_cookies('https://localhost/')).to have(1).items | ||
| expect(jar.get_cookies('https://localhost/').size).to eql(1) |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| jar = Jar.json_create hash | ||
| expect(jar.get_cookies('https://localhost/')).to have(1).items | ||
| expect(jar.get_cookies('https://localhost/').size).to eql(1) |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| jar = Jar.json_create array | ||
| expect(jar.get_cookies('https://localhost/')).to have(1).items | ||
| expect(jar.get_cookies('https://localhost/').size).to eql(1) |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| jar.set_cookie 'http://auth.foo.com/', 'foo=bar' | ||
| jar.set_cookie 'http://auth.foo.com/', 'auth=135121...;domain=foo.com' | ||
| expect(jar.get_cookies('http://foo.com/')).to have(3).items | ||
| expect(jar.get_cookies('http://foo.com/').size).to eql(3) |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Just FTR, it seems that the |
2 participants
This does not really really add to readability while one less dependency is beneficial.