refactor: codebase quality remediation#58
Merged
dwsmith1983 merged 5 commits intomainfrom Mar 8, 2026
Merged
Conversation
Split the 1,129-line stream_router.go monolith into 5 focused files: - stream_router.go (~249 lines): core routing, sensor eval, job events - sfn.go (~119 lines): SFN execution and config builders - dynstream.go (~254 lines): DynamoDB stream helpers, calendar, publishing - rerun.go (~384 lines): rerun handling, circuit breaker, late data - postrun.go (~166 lines): post-run drift detection Also: - Centralize magic constants in defaults.go - Extract DynamoDB pagination helpers (ScanAll, QueryAll, QueryCount) - Refactor control.go and rerun.go to use pagination helpers
- Merge isExcludedDate/isExcluded into shared isExcludedTime core with resolveTimezone helper (eliminates duplicated logic) - Add trigger status_test.go, Databricks/EMR Serverless edge cases - Add calendar registry tests (96.6% coverage, up from 72.4%) - Add unit tests for ParseExecutionDate, InjectDateArgs, RemapPerPeriodSensors
- Add ValidateEnv() for fail-fast on missing env vars at cold start - Call ValidateEnv in all 6 cmd/lambda/*/main.go entry points - Add package-level godoc for internal/lambda/ and internal/trigger/
Add Runner.Execute dispatch tests for all 10 trigger types, Airflow status check tests, EMR edge cases, and CheckStatus dispatch coverage. Coverage: trigger 72.9% -> 85.8%, calendar 96.6%, lambda 86.8%, store 92.0%
- Preserve original timezone in isExcluded when no timezone configured (avoids subtle behavioral change from refactor) - Fix double error prefix in ScanConfigs pagination refactor - Add SLACK_BOT_TOKEN to alert-dispatcher required env vars
github-actions
bot
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_router.go(1,129 → 249 lines) into 5 focused files:sfn.go,dynstream.go,rerun.go,postrun.go, and the slimmedstream_router.goisExcludedTime+resolveTimezonehelpersScanAll,QueryAll,QueryCount) eliminating 5 instances of boilerplatedefaults.goParseExecutionDate,InjectDateArgs,RemapPerPeriodSensorsValidateEnv()for fail-fast on missing env vars at Lambda cold startinternal/lambda/andinternal/trigger/