Skip to content

fix: add missing DynamoDB env vars and IAM for sla-monitor #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwsmith1983 merged 1 commit into from
Mar 8, 2026
Merged

fix: add missing DynamoDB env vars and IAM for sla-monitor #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions deploy/terraform/lambda.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ resource "aws_lambda_function" "sla_monitor" {

environment {
variables = {
CONTROL_TABLE = aws_dynamodb_table.control.name
JOBLOG_TABLE = aws_dynamodb_table.joblog.name
RERUN_TABLE = aws_dynamodb_table.rerun.name
EVENT_BUS_NAME = aws_cloudwatch_event_bus.interlock.name
SLA_MONITOR_ARN = "arn:aws:lambda:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:function:${var.environment}-interlock-sla-monitor"
SCHEDULER_ROLE_ARN = aws_iam_role.scheduler_sla.arn
Expand Down Expand Up @@ -304,6 +307,30 @@ resource "aws_iam_role_policy" "dynamodb_watchdog" {
policy = data.aws_iam_policy_document.dynamodb_watchdog.json
}

# -----------------------------------------------------------------------------
# DynamoDB read — sla-monitor (control + joblog, read-only for alert suppression)
# -----------------------------------------------------------------------------

data "aws_iam_policy_document" "dynamodb_sla_read" {
statement {
sid = "ReadControlJoblog"
actions = [
"dynamodb:GetItem",
"dynamodb:Query",
]
resources = [
aws_dynamodb_table.control.arn,
aws_dynamodb_table.joblog.arn,
]
}
}

resource "aws_iam_role_policy" "dynamodb_sla_read" {
name = "dynamodb-read"
role = aws_iam_role.lambda["sla-monitor"].id
policy = data.aws_iam_policy_document.dynamodb_sla_read.json
}

# -----------------------------------------------------------------------------
# EventBridge PutEvents — all 4 functions
# -----------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion internal/lambda/envcheck.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
// it requires at startup. Missing vars cause a fail-fast with a clear message.
var requiredEnvVars = map[string][]string{
"stream-router": {"CONTROL_TABLE", "JOBLOG_TABLE", "RERUN_TABLE", "STATE_MACHINE_ARN", "EVENT_BUS_NAME"},
"orchestrator": {"CONTROL_TABLE", "JOBLOG_TABLE", "RERUN_TABLE", "STATE_MACHINE_ARN", "EVENT_BUS_NAME"},
"orchestrator": {"CONTROL_TABLE", "JOBLOG_TABLE", "RERUN_TABLE", "EVENT_BUS_NAME"},
"watchdog": {"CONTROL_TABLE", "JOBLOG_TABLE", "RERUN_TABLE", "EVENT_BUS_NAME"},
"sla-monitor": {"CONTROL_TABLE", "JOBLOG_TABLE", "RERUN_TABLE", "EVENT_BUS_NAME", "SLA_MONITOR_ARN", "SCHEDULER_ROLE_ARN", "SCHEDULER_GROUP_NAME"},
"event-sink": {"EVENTS_TABLE"},
Expand Down