fix: configurable drift detection field and flaky test fixes#63
Merged
dwsmith1983 merged 3 commits intomainfrom Mar 9, 2026
Merged
fix: configurable drift detection field and flaky test fixes#63dwsmith1983 merged 3 commits intomainfrom
dwsmith1983 merged 3 commits intomainfrom
Conversation
Drift detection was hardcoded to compare `sensor_count` but bronze consumers write `count`. Add `DriftField` to PostRunConfig so operators can target the correct sensor field. Defaults to `sensor_count` for backward compatibility.
TestSLAMonitor_Reconcile_PastWarningFutureBreach and TestWatchdog_MissedSchedule_DetailFields used real wall-clock time, causing failures depending on time of day. Inject NowFunc so both tests use a fixed timestamp independent of when they run.
github-actions
bot
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DriftFieldinPostRunConfig— drift detection was hardcoded to comparesensor_countbut bronze consumers writecountin hourly-status sensors, silently suppressing all post-run drift detection. The new field defaults tosensor_countfor backward compatibility.TestSLAMonitor_Reconcile_PastWarningFutureBreachandTestWatchdog_MissedSchedule_DetailFieldsused real wall-clock time instead of injectedNowFunc, causing time-of-day dependent failures.