fix: resolve SLA deadline to T+1 for sensor-triggered daily pipelines#64
Merged
dwsmith1983 merged 3 commits intomainfrom Mar 10, 2026
Merged
fix: resolve SLA deadline to T+1 for sensor-triggered daily pipelines#64dwsmith1983 merged 3 commits intomainfrom
dwsmith1983 merged 3 commits intomainfrom
Conversation
Sensor-triggered daily pipelines process today's data tomorrow, but scheduleSLAAlerts resolved the SLA deadline against today's date. Between 00:00 and the deadline hour, the breach time landed on the same day instead of the next day, causing false SLA warnings and breaches. Shift the date passed to handleSLACalculate by +1 day when the pipeline is sensor-triggered (no cron) with a daily deadline (HH:MM, not :MM).
github-actions
bot
added
tests
9 subtests covering midnight window, after-deadline, pre-midnight, month boundary, year boundary, leap year, non-leap year, and two negative cases (cron daily and hourly sensor should not shift).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduleSLAAlertsresolved the SLA deadline against today's date, but sensor-triggered daily pipelines run T+1 (data for today completes tomorrow). Between 00:00 UTC and the deadline hour, the breach time landed on the same day, causing premature alerts.handleSLACalculateby +1 day when the pipeline has no cron and uses a dailyHH:MMdeadline. Hourly (:MM) and cron-based pipelines are unaffected.