This repository was archived by the owner on Jun 2, 2023. It is now read-only.
fix(metadataRetriever): get tabs with tooling api#749
Open
ghost wants to merge 2 commits intodxatscale:mainfrom
Open
fix(metadataRetriever): get tabs with tooling api#749ghost wants to merge 2 commits intodxatscale:mainfrom
ghost wants to merge 2 commits intodxatscale:mainfrom
Conversation
added 2 commits
December 12, 2022 14:50
…visibilities fix(metadataRetriever): get tabs with tooling api
Author
|
@ethan-sargent I took a quick look to the smoke-tests execution and saw the issue is related to the DevHub authentication. Could you help with that? |
|
@azlam-abdulsalam can you please grant access so I can view the pipeline secrets? |
|
@mmoya-sage looks good to me! Will merge once I can resolve the CI issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #737 and #738
Summary of changes
It looks like the Tooling API returns more
TabDefinitions records (and therefore more accurate) than the SOAP API.These are the ones which are mentioned to be missing in #737.
They are now included in the
sfpowerkit:source:profile:retrievaland retained in thesfpowerkit:source:profile:reconcilecommand.Here is the diff from the output of running
sfdx force:data:soql:query -q "SELECT Name FROM TabDefinition"vs.
sfdx force:data:soql:query -q "SELECT Name FROM TabDefinition" --usetoolingapiChecklist
sfpowerkit:source:profile:retrievalandsfpowerkit:source:profile:reconcilecommands