[doc] Add take a tour functionality#2469
Open
PelayoFelgueroso wants to merge 10 commits intomasterfrom
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Jialecl
requested changes
May 4, 2026
Co-authored-by: Copilot <copilot@github.com>
…eme-tour' of https://github.com/dxc-technology/halstack-react into PelayoFelgueroso/theme-tour
Co-authored-by: Copilot <copilot@github.com>
Jialecl
requested changes
May 6, 2026
| }; | ||
|
|
||
| const joyrideOptions = { | ||
| overlayClickAction: false as const, |
Collaborator
There was a problem hiding this comment.
Why is "as const" needed here?
If joyrideOptions is correctly typed I do not think this is needed.
| return ( | ||
| <> | ||
| {currentStep === 0 && ( | ||
| <Joyride |
Collaborator
There was a problem hiding this comment.
We can reduce some code repition if we create a wrapper component for Joyride, since the only difference is the steps prop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
Add take a tour functionality to the Theme Generator