Open
Conversation
Make length prefix usable more that once
Author
|
I also implemented the possibility to use a length prefix multiple time like this : #[derive(Protocol, Debug, PartialEq, Eq)]
pub struct WithElementsLengthUsedTwice {
pub count: u32,
pub foo: bool,
#[protocol(length_prefix(elements(count)))]
pub data_1: Vec<u32>,
#[protocol(length_prefix(elements(count)))]
pub data_2: Vec<u32>,
}@dylanmckay I am waiting for your feedback before updating the documentation. |
Author
|
I started to work on a "skip_if" attribute, for now the derive implementation is quite naive (and only It looks like this : #[derive(Protocol, Debug, PartialEq, Eq)]
struct SkipIfField {
pub condition: bool,
#[protocol(skip_if("condition"))]
pub message: Option<u8>,
}
#[derive(Protocol, Debug, PartialEq, Eq)]
struct SkipIfBinaryExp {
pub condition: u8,
#[protocol(skip_if("condition == 7"))]
pub message: Option<u8>,
}This only works on struct named field, I don't know if we want this for other kind of field. |
|
This is a feature I'd also like! @dylanmckay is there a chance this will be merged? I don't mind helping to finish up the docs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented what I asked for in #25
Let me know if you think that might be useful and if I need to change anything.