Fix MRMS RadarOnly fallback when system publishes files late within the hour#482
Draft
Copilot wants to merge 2 commits intoclaude/implement-noaa-mrms-conus-oYYudfrom
Draft
Conversation
…0:00 is missing Co-authored-by: aldenks <463484+aldenks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Run dataset validation plots on icechunk v0.2.0 for missing data
Fix MRMS RadarOnly fallback when system publishes files late within the hour
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RadarOnly_QPE_01His published at 2-minute intervals. When the MRMS system starts late, the file for a given hour lands at e.g.20210916-220800instead of20210916-220000. The existing code tries only the exactHH:00:00filename, gets a 404, and writes NaN — even though valid data for that hour exists.Investigation confirmed this via S3 directory listings and rasterio inspection of the off-minute files (e.g.
220800,001000,181800,190800), which all contain valid precipitation data. The remaining missing timestamps are genuine MRMS system outages where all three products are absent from S3.Changes
download.py: Adds3_list_first_key_with_prefix(base_url, key_prefix)— uses the S3 XML list API to return the first key matching a prefix, orNoneif empty. Prefix is URL-encoded.noaa/mrms/.../region_job.py: In_download_from_source, after aFileNotFoundErroron an S3RadarOnly_QPE_*download, list the hour's directory prefix and retry with the first file found. Non-RadarOnly products and non-S3 sources re-raise immediately without the listing roundtrip.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
mirrors.aliyun.com/home/REDACTED/work/reformatters/reformatters/.venv/bin/prek /home/REDACTED/work/reformatters/reformatters/.venv/bin/prek hook-impl --hook-dir /home/REDACTED/work/reformatters/reformatters/.git/hooks --script-version 4 --hook-type=pre-commit -- k/reformatters/runame k/reformatters/r-p k/reformatters/reformatters/.ven--noprofile k/reformatters/reformatters/.venv/lib/python3.13/site-packages/k/tmp/copilot-tool-output-1772496512497-zgbz0h.txt k/re�� k/reformatters/reformatters/.venv/lib/python3.13/site-packages/kubernetes/client/models/v1_priorsh k/reformatters/reformatters/.venv/lib/python3.13/site-packages/kubernetes/client/models/v1_node_-c bash /region_job.py(dns block)mirrors.cloud.tencent.com/home/REDACTED/work/reformatters/reformatters/.venv/bin/prek /home/REDACTED/work/reformatters/reformatters/.venv/bin/prek hook-impl --hook-dir /home/REDACTED/work/reformatters/reformatters/.git/hooks --script-version 4 --hook-type=pre-commit -- k/reformatters/runame k/reformatters/r-p k/reformatters/reformatters/.ven--noprofile k/reformatters/reformatters/.venv/lib/python3.13/site-packages/k/tmp/copilot-tool-output-1772496512497-zgbz0h.txt k/re�� k/reformatters/reformatters/.venv/lib/python3.13/site-packages/kubernetes/client/models/v1_priorsh k/reformatters/reformatters/.venv/lib/python3.13/site-packages/kubernetes/client/models/v1_node_-c bash /region_job.py(dns block)mtarchive.geol.iastate.edu/home/REDACTED/work/reformatters/reformatters/.venv/bin/python3 /home/REDACTED/work/reformatters/reformatters/.venv/bin/python3 t.py(dns block)/home/REDACTED/work/reformatters/reformatters/.venv/bin/python /home/REDACTED/work/reformatters/reformatters/.venv/bin/python -u -c import sys;exec(eval(sys.stdin.readline()))(dns block)pypi.tuna.tsinghua.edu.cn/home/REDACTED/work/reformatters/reformatters/.venv/bin/prek /home/REDACTED/work/reformatters/reformatters/.venv/bin/prek hook-impl --hook-dir /home/REDACTED/work/reformatters/reformatters/.git/hooks --script-version 4 --hook-type=pre-commit -- k/reformatters/runame k/reformatters/r-p k/reformatters/reformatters/.ven--noprofile k/reformatters/reformatters/.venv/lib/python3.13/site-packages/k/tmp/copilot-tool-output-1772496512497-zgbz0h.txt k/re�� k/reformatters/reformatters/.venv/lib/python3.13/site-packages/kubernetes/client/models/v1_priorsh k/reformatters/reformatters/.venv/lib/python3.13/site-packages/kubernetes/client/models/v1_node_-c bash /region_job.py(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.