fix: prevent OOM in analyze by adding cycle detection and caching#174
Open
fix: prevent OOM in analyze by adding cycle detection and caching#174
analyze by adding cycle detection and caching#174Conversation
commit: |
dreyfus92
changed the title
analyze by adding cycle detection and caching
|
I tried it locally and it seems to work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
analyzecommand could hang and exhaust RAM because dependency traversal had no cycle detection, so circular deps (e.g. A → B → A) caused infinite recursion. this PR adds a visited set to avoid re-entering the same package, uses a map package lookups, cachesgetPackageJsonreads, and unifies the twonode_modulescrawls into one.closes: #173