Merged
Conversation
Adding to_logical_1 to convert string into bool by using to_logical method.
Now we can get pointer to IntVector by using GetPointer() without any datatype argument.
Using the range of matrices in methods related to Set1 and Set4. This is because, we get node coord from mesh, we get the 3 components even for a 2D problem. It causes some issue in while setting global element shape data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates across multiple modules to improve documentation, enhance functionality, and fix inconsistencies. Key changes include improved comments and metadata, updates to subroutine arguments, and adjustments to procedural implementations for better clarity and maintainability.
Documentation Improvements
obj_Initiate8,obj_Initiate9, andto_logical_1insrc/modules/QuadraturePoint/src/QuadraturePoint_Method.F90andsrc/modules/String/src/String_Class.F90. [1] [2] [3]Code Refactoring and Clarifications
obj_Initiate4andobj_Initiate10. [1] [2]elemsd_SetBarycentricCoordandelemsd_SetJacobianfor better readability and performance insrc/submodules/ElemshapeData/src/ElemshapeData_SetMethods@Methods.F90. [1] [2]Modular Enhancements
GetPointerinterface insrc/modules/IntVector/src/IntVector_GetMethod.F90to provide additional functionality for accessing raw data pointers.to_logical_1function insrc/modules/String/src/String_Class.F90to extend string-to-logical casting capabilities.Code Cleanup
USEstatements inElemshapeData_Method.F90for better modularity and removed unused dependencies. [1] [2].incfile references with.F90files insrc/submodules/IntVector/src/IntVector_GetMethod@Methods.F90for consistency and maintainability.These changes collectively improve the codebase's clarity, maintainability, and functionality while adhering to best practices.