Merged
Conversation
Update project metadata in FORDsetup (project summary and GitHub/download URLs). In ARPACK_SAUPD.F90: add author/header comments, export SAUPD_ErrorMsg, SEUPD_ErrorMsg, SymLargestEigenVal and SymSmallestEigenVal, and rename/clean up INTERFACE blocks for the symmetric eigenvalue routines (adjusted function/interface declarations and formatting). In String_Class.F90: fix continuation/indentation and alignment for alphabet constants and tidy INTERFACE continuation lines for several string routines.
updating the code structure of system_method. Fixing the documentation.
Refactor the System module by extracting method groups into separate Fortran sources and submodules for clarity and maintainability. Added new method files (SystemEnquiry_Method.F90, SystemEnvironment_Method.F90, SystemFile_Method.F90, SystemOptions.F90, SystemProcess_Method.F90, SystemSignal_Method.F90, System_Utility.F90) and updated src/modules/System/CMakeLists.txt to include them. Updated existing interfaces (SystemInterface.F90, System_Method.F90) and adjusted submodule filenames/renames under src/submodules/System (including removal of the old GetMethods file). Also added a .helix/config.toml editor setting to define workspace LSP roots. These changes modularize code originally sourced from M_system into discrete components for easier maintenance and compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refinements across configuration, documentation, and source files. The main changes include expanded Fortran source file inclusion in the System module, enhanced ARPACK interface definitions, improved Fortran code formatting, and updates to project metadata and linting configurations.
Build system and configuration enhancements:
src/modules/System/CMakeLists.txtto include multiple Fortran source files, improving modularity and maintainability of the System module. Also updated target properties formatting for clarity and consistency. [1] [2].helix/config.tomlto specify workspace LSP roots for improved editor integration.fortitude.tomlto enable automatic code fixes, add ignored linting rules, and adjust selection criteria for Fortran linting.ARPACK interface and documentation improvements:
src/modules/ARPACK/src/ARPACK_SAUPD.F90, including adding author and summary metadata, and improving the structure and visibility of eigenvalue calculation routines. [1] [2] [3] [4] [5] [6] [7] [8]Code formatting and cleanup:
src/modules/String/src/String_Class.F90by removing unnecessary line continuations and aligning interface definitions for readability. [1] [2] [3] [4]src/modules/Display/src/Display_Method.F90to simplify theEqualLinesubroutine, using direct format strings for output.Documentation and metadata updates:
FORDsetup.mdto correct project summary and links, and removed extraneous documentation comments for clarity. [1] [2]These changes collectively improve the project's structure, maintainability, and developer experience.