fix: use $PSScriptRoot instead of MyCommand.Path in install.ps1#1166
fix: use $PSScriptRoot instead of MyCommand.Path in install.ps1#1166chumyin merged 1 commit intoeastreams:devfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PowerShell install script now uses Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
41c8409 to
b28a3d5
Compare
|
merge dev to solve cargo audit failure. |
241cb1d to
a5bb586
Compare
this fixes a powershell source install error where `$MyInvocation.MyCommand.Path` can be null in some environments. using `$PSScriptRoot` is the standard and more reliable way to resolve the script directory on powershell 3.0+. fixes the failure where `install.ps1 -Source` can raise: `ParentContainsErrorRecordException: The property Path cannot be found`
a5bb586 to
b894467
Compare
|
hey @attolee, thanks for chasing this powershell edge case. i rebased the branch onto current |
this fixes a powershell source install error where
$MyInvocation.MyCommand.Pathcan be null in some environments.using
$PSScriptRootis the standard and more reliable way to resolve the script directory on powershell 3.0+.fixes the failure where
install.ps1 -Sourcecan raise:ParentContainsErrorRecordException: The property Path cannot be found