-
Notifications
You must be signed in to change notification settings - Fork 1
Fixes and cleanups after applying Copier templates #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #82 +/- ##
===========================================
- Coverage 98.10% 97.66% -0.44%
===========================================
Files 21 28 +7
Lines 1055 1458 +403
Branches 0 237 +237
===========================================
+ Hits 1035 1424 +389
+ Misses 20 19 -1
- Partials 0 15 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
2 similar comments
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
henrikjacobsenfys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for all of it, also for the improved fix of the global map problem I've been having.
I don't dare merge it myself ;)
This PR contains a set of follow-up fixes and adjustments after applying the updated Copier templates.
Changes
Adapted the project to the updated Copier template structure (see https://github.com/easyscience/templates for details)
CI runs on Python 3.11 and 3.12, with 3.12 as the default.
Updated
reset_global_objectinconftest.py. This is a temporary workaround that requires running pytest with the--cov= --cov-report=flags to pass, but it speeds up unit tests by roughly 5–10×.Can be run as:
Enabled Ruff linting and formatting checks (see pyproject.toml) and updated the codebase to comply with them.
Temporarily disabled pre-commit and pre-push hooks to ease the transition.
They can be re-enabled later with:
Added missing documentation assets and fixed several docs issues, allowing the docs to auto-build successfully at:
https://easyscience.github.io/dynamics-lib/dev/
All documentation versions are now stored in a dedicated gh-pages branch (https://github.com/easyscience/dynamics-lib/tree/gh-pages). The branch contains subfolders named after each release tag, as well as a
devsubfolder used for all branches (feature branches, develop, and master).Jupyter notebook examples have been moved from
examples/todocs/docs/tutorials/as they are now part of the built documentation.To run them locally from the project root (Use the
pixi kernelwhen running the notebooks):Fixed several broken CI workflows