Allow for the certificate file to be passed in through the providerArg parameter#275
Open
efetoboreakpoguma wants to merge 2 commits intoebourg:masterfrom
Open
Allow for the certificate file to be passed in through the providerArg parameter#275efetoboreakpoguma wants to merge 2 commits intoebourg:masterfrom
efetoboreakpoguma wants to merge 2 commits intoebourg:masterfrom
Conversation
the configArg can be null, contain just the keystore or contain both the keystore and certfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backgroud
Please see the details about this bug here.
Possible Solution
There are several solutions to this issue but I have opted to go with this one as it involves the smallest possible change.
Currently, the
configArgis used to pass in thekeyStorevalue to theJsignJcaProvider. This PR adds the ability to pass in a comma-separated as theconfigArgwhere the first element iskeyStoreand the second element is theconfigArg.Also, the
configArgcan:null.keystore.keystoreandcertfile.Testing
See the passed build here.
Summary
As I said above, this is a possible solution. If you decide to go with this approach, we would need to update the docs.