upgrade template to v8.3.1 and fix linters#191
Merged
louiswesterheide merged 10 commits intomainfrom Mar 5, 2026
Merged
Conversation
Coverage Report
|
- Treat _QUEUE_FULL as a clean stop signal in poll() instead of raising KafkaException, so the streaming generators terminate normally and the closing ] / </KafkaMessages> tags are always emitted and the offset is committed for successfully consumed messages - Restructure JSON _aggregate_data() to compute each chunk before yielding so a failed message never leaves a dangling comma in the output - Wrap get_entities() loop in try/finally to guarantee the consumer is always closed even when an exception propagates
Assign msg.error() to a local variable so mypy can narrow the type from KafkaError | None to KafkaError within the if-block.
Replace hardcoded relative paths (tests/sample-test.*) with Path(FIXTURES_DIR / ...) so tests work regardless of the working directory. Add FIXTURES_DIR to tests/utils.py and fix the security_protocol default value in get_kafka_config().
louiswesterheide
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.