-
Notifications
You must be signed in to change notification settings - Fork 6
External import fixes #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdd an import-step validation and UI warning for existing external tokens, require all derived wallet addresses before continuing, always include hive key data in private API calls, add a loading state for token address items, and allow wallet creation to accept an imported seed. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant UI as SetupExternalImport (Client)
participant Deriver as WalletDerivationService
participant API as Private API
User->>UI: Start import (seed or link)
UI->>Deriver: Request address derivation for configured tokens
Deriver-->>UI: Return derived addresses (incremental)
UI->>UI: compute allWalletsDerived & hasExistingChainTokens
alt hasExistingChainTokens
UI-->>User: Show existing-tokens-warning, require confirmation
end
User->>UI: Continue (only when allWalletsDerived true)
UI->>API: Send link/save payload (always includes hiveKeys)
API-->>UI: Success / Error
UI-->>User: Show result (spinner while pending / final state)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Bug Fixes