Resolve some warnings during pytest#1731
Open
gavinmacaulay wants to merge 4 commits into
Open
Conversation
- colormap set_under and set_over are deprecated. Use .with_extremes instead, which accepts under=None and over=None, so _create_cmap() and other code simplifies to one or two lines. - specify the xarray concat default join parameter in places as the default will change in future xarray versions These changes reduce the number of warnings during the test run by about 200.
- Ignoring some warnings that come from echopype dependency libraries - The ZarrUserWarning is ignored for the moment because there are a lot of them that obscure other warnings Total warnings from tests are now 35.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves or configures pytest to ignore warnings generated when running pytest.
Most of the ignored warnings are from dependency libraries that need to update themselves (i.e., echopype can't resolve them). One exclusion is probably addressable by a change in echopype, but it generates so many warnings that it obscures the less frequent ones.
The warnings that remain are now much more visible in the output that pytest produces.