Skip to content

chore: group EK60 and EK80 model families#1738

Open
praneethratna wants to merge 5 commits into
echostack-org:mainfrom
praneethratna:consolidate-models
Open

chore: group EK60 and EK80 model families#1738
praneethratna wants to merge 5 commits into
echostack-org:mainfrom
praneethratna:consolidate-models

Conversation

@praneethratna

Copy link
Copy Markdown
Contributor

Closes #1729.

Groups EK60 and EK80 model into different families to avoid if else across the code.

@praneethratna
praneethratna requested a review from leewujung July 24, 2026 17:48
Comment thread echopype/core.py
Comment thread echopype/calibrate/range.py
leewujung
leewujung previously approved these changes Jul 25, 2026

@leewujung leewujung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @praneethratna : Thank you so much for the PR! This is pretty much ready to go! A tiny thing (which was my bad in my original description) -- could you change EX60 to Ex60 and EX80 to Ex80? Just wanted to be consistent with the manufacturer usage. Also it's somehow easier to read the difference since it's lower case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate handling of sonar_model types

2 participants