Skip to content

Reduce/change 3rd party dependencies#130

Merged
Korbik merged 12 commits into
eclipse-biscuit:mainfrom
preuss-adam:apreuss/reduce-dependencies
Aug 13, 2025
Merged

Reduce/change 3rd party dependencies#130
Korbik merged 12 commits into
eclipse-biscuit:mainfrom
preuss-adam:apreuss/reduce-dependencies

Conversation

@preuss-adam

Copy link
Copy Markdown
Contributor

This PR is best reviewed commit-by-commit. At a high level, it comprises of two major changes:

  1. Replace gson library with the more modern and maintained jackson.
  2. Remove vavr dependency, replacing with builtins and custom types where necessary.

@KannarFr

KannarFr commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Wow, a big one, but very nice. Thanks!

@Korbik Korbik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Some suggestions

Comment thread src/main/java/org/eclipse/biscuit/error/Result.java Outdated
Comment thread src/main/java/org/eclipse/biscuit/datalog/Rule.java Outdated
Comment thread src/main/java/org/eclipse/biscuit/datalog/Rule.java Outdated
Comment thread src/main/java/org/eclipse/biscuit/datalog/Rule.java Outdated
Comment thread src/main/java/org/eclipse/biscuit/datalog/Rule.java Outdated
Comment thread src/main/java/org/eclipse/biscuit/datalog/Rule.java Outdated
Comment thread src/main/java/org/eclipse/biscuit/error/Result.java Outdated
Comment thread src/main/java/org/eclipse/biscuit/error/Result.java Outdated
@preuss-adam preuss-adam force-pushed the apreuss/reduce-dependencies branch from 875f3b5 to b0dd7dc Compare August 13, 2025 15:59
@preuss-adam preuss-adam requested a review from Korbik August 13, 2025 15:59
@preuss-adam

Copy link
Copy Markdown
Contributor Author

@Korbik thanks for review. changes are pushed.

@preuss-adam preuss-adam force-pushed the apreuss/reduce-dependencies branch from b0dd7dc to 9340b20 Compare August 13, 2025 16:37
@Korbik Korbik merged commit ecb226f into eclipse-biscuit:main Aug 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants