Eliminate unnecessary cloning in any/all loop#324
Merged
divarvel merged 1 commit intoApr 22, 2026
Conversation
The RHS expression only needs to be constructed once, not repeatedly inside the loop, because evaluating it does not consume it.
divarvel
approved these changes
Apr 16, 2026
divarvel
left a comment
divarvel
left a comment
Contributor
There was a problem hiding this comment.
Neat! How did you notice it?
Contributor
Author
|
I asked Claude to identify low hanging fruit for optimising the authorisation logic; it identifies this issue as well as #325 (and also several non-issues naturally) and then I implemented these changes by hand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RHS expression only needs to be constructed once, not repeatedly inside the loop, because evaluating it does not consume it.