Skip to content

refactor: remove backend user profile route and use Che server endpoint directly#1569

Closed
vinokurig wants to merge 1 commit into
mainfrom
CRW-10682
Closed

refactor: remove backend user profile route and use Che server endpoint directly#1569
vinokurig wants to merge 1 commit into
mainfrom
CRW-10682

Conversation

@vinokurig
Copy link
Copy Markdown
Contributor

What does this PR do?

In some circumstances, e.g., a high-load OpenShift cluster, creating or updating a Kubernetes secret may take some time (it is not instant). If reading the user-profile secret occurs during the create or update operation of the secret, an error is thrown. In order to avoid this race condition, request the user from the che-server API instead of reading the user-profile secret directly.

DO NOT MERGE until eclipse-che/che-server#1018 is merged.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://redhat.atlassian.net/browse/CRW-10682

Is it tested? How?

N/A

Release Notes

Docs PR

@che-bot
Copy link
Copy Markdown
Contributor

che-bot commented May 18, 2026

Click here to review and test in web IDE: Contribute

@github-actions
Copy link
Copy Markdown

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1569 (linux/amd64, linux/arm64)

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1569", name: che-dashboard}]}}]"

@vinokurig
Copy link
Copy Markdown
Contributor Author

/retest

@github-actions
Copy link
Copy Markdown

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1569 (linux/amd64, linux/arm64)

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1569", name: che-dashboard}]}}]"

@vinokurig
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@vinokurig
Copy link
Copy Markdown
Contributor Author

/retest

Copy link
Copy Markdown
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hold until eclipse-che/che-server#1018 lands

@openshift-ci openshift-ci Bot added the lgtm label May 20, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4, vinokurig

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig
Copy link
Copy Markdown
Contributor Author

/retest

…nt directly

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 26, 2026

New changes are detected. LGTM label has been removed.

@github-actions
Copy link
Copy Markdown

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1569 (linux/amd64, linux/arm64)

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1569", name: che-dashboard}]}}]"

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 26, 2026

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v19-dashboard-happy-path 10f6652 link true /test v19-dashboard-happy-path

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tolusha
Copy link
Copy Markdown
Contributor

tolusha commented Jun 3, 2026

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

  • /che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
  • /che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
  • /che-ai-assistant help — Show this help message

@vinokurig vinokurig closed this Jun 5, 2026
@vinokurig
Copy link
Copy Markdown
Contributor Author

Closed in favor of #1587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants