Conversation
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1569 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1569", name: che-dashboard}]}}]" |
|
/retest |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1569 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1569", name: che-dashboard}]}}]" |
|
/retest |
1 similar comment
|
/retest |
olexii4
left a comment
There was a problem hiding this comment.
LGTM
Hold until eclipse-che/che-server#1018 lands
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, vinokurig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
…nt directly Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
New changes are detected. LGTM label has been removed. |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1569 (linux/amd64, linux/arm64) kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1569", name: che-dashboard}]}}]" |
|
@vinokurig: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
|
Closed in favor of #1587 |
What does this PR do?
In some circumstances, e.g., a high-load OpenShift cluster, creating or updating a Kubernetes secret may take some time (it is not instant). If reading the
user-profilesecret occurs during the create or update operation of the secret, an error is thrown. In order to avoid this race condition, request the user from theche-serverAPI instead of reading theuser-profilesecret directly.DO NOT MERGE until eclipse-che/che-server#1018 is merged.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://redhat.atlassian.net/browse/CRW-10682
Is it tested? How?
N/A
Release Notes
Docs PR