Skip to content

docs: fix claude mcp add argument order in K8s proxy example - #18

Closed
akurinnoy wants to merge 1 commit into
mainfrom
fix/readme-mcp-add-syntax
Closed

docs: fix claude mcp add argument order in K8s proxy example#18
akurinnoy wants to merge 1 commit into
mainfrom
fix/readme-mcp-add-syntax

Conversation

@akurinnoy

@akurinnoy akurinnoy commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Move --header after positional args (name + URL) in the K8s API proxy example
  • The --header option is variadic (<header...>) and greedily consumes subsequent arguments when placed before the name, causing error: missing required argument 'name'

Test plan

  • Run the corrected command from the README against a live cluster

Summary by CodeRabbit

  • Documentation
    • Updated the README command example for the Claude Code K8s API service proxy.
    • Reordered the command arguments in the setup snippet for improved clarity and consistency.

The --header option is variadic (<header...>) and greedily consumes
subsequent positional arguments when placed before the name and URL.
Move --header after the positional args to match the CLI's expected
syntax.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
akurinnoy requested a review from tolusha as a code owner July 9, 2026 14:32
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 88b80de1-cb31-404d-84b4-e48a6208df97

📥 Commits

Reviewing files that changed from the base of the PR and between 84afa35 and 29d57bc.

📒 Files selected for processing (1)
  • README.md

📝 Walkthrough

Walkthrough

Reordered arguments in the README's claude mcp add example command for the K8s API service proxy, moving the che-mcp URL argument before the --header "Authorization: Bearer $(oc whoami -t)" line.

Changes

README command snippet reorder

Layer / File(s) Summary
Reorder claude mcp add arguments
README.md
The che-mcp URL argument now appears before the --header "Authorization: Bearer $(oc whoami -t)" line in the example command.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the documentation fix to the K8s proxy example and the argument order change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/readme-mcp-add-syntax

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Image built: quay.io/che-incubator/che-mcp-server:pr-18

@akurinnoy

Copy link
Copy Markdown
Contributor Author

Closing — the K8s API service proxy approach doesn't work in practice. The user lacks services/proxy RBAC permission (standard OpenShift DevSpaces setup doesn't grant it), so all requests through the API proxy time out silently. Will remove this section from the README entirely.

@akurinnoy akurinnoy closed this Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant