Skip to content

fix(deploy): set CHE_MCP_MODE=full in deployment manifest - #21

Merged
akurinnoy merged 1 commit into
mainfrom
fix/deploy-full-mode
Jul 9, 2026
Merged

fix(deploy): set CHE_MCP_MODE=full in deployment manifest#21
akurinnoy merged 1 commit into
mainfrom
fix/deploy-full-mode

Conversation

@akurinnoy

@akurinnoy akurinnoy commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add CHE_MCP_MODE=full to the deployment manifest so fresh deployments expose all 22 tools including terminal sessions and exec_in_workspace
  • Without this, deployments default to orchestration mode which hides terminal tools from all clients

Context

Per-client tool visibility is tracked in akurinnoy/agentic-workspaces#239. For now, all tools are exposed and access is constrained by agent protocol rules.

Summary by CodeRabbit

  • New Features
    • The deployment now includes an additional runtime setting that enables full MCP mode alongside the existing transport configuration.

Without this, fresh deployments default to orchestration mode which
hides terminal tools (exec_in_workspace, start_terminal_session, etc.)
from all clients.

Refs: akurinnoy/agentic-workspaces#239

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
akurinnoy requested a review from tolusha as a code owner July 9, 2026 19:40
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 457db5bb-4d2c-4357-adf6-7c80c34c9ba2

📥 Commits

Reviewing files that changed from the base of the PR and between ca77a04 and daccc3a.

📒 Files selected for processing (1)
  • deploy/deployment.yaml

📝 Walkthrough

Walkthrough

The Kubernetes deployment manifest adds a new container environment variable, CHE_MCP_MODE, set to "full", alongside the existing CHE_MCP_TRANSPORT variable.

Changes

Deployment environment configuration

Layer / File(s) Summary
Add CHE_MCP_MODE env variable
deploy/deployment.yaml
Adds the CHE_MCP_MODE container environment variable set to "full" to the deployment spec.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main deployment manifest change: setting CHE_MCP_MODE=full.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deploy-full-mode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Image built: quay.io/che-incubator/che-mcp-server:pr-21

@akurinnoy
akurinnoy merged commit 9d2a0d2 into main Jul 9, 2026
3 checks passed
@akurinnoy
akurinnoy deleted the fix/deploy-full-mode branch July 9, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant