fix(deploy): set CHE_MCP_MODE=full in deployment manifest - #21
Merged
Conversation
Without this, fresh deployments default to orchestration mode which hides terminal tools (exec_in_workspace, start_terminal_session, etc.) from all clients. Refs: akurinnoy/agentic-workspaces#239 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Kubernetes deployment manifest adds a new container environment variable, CHE_MCP_MODE, set to "full", alongside the existing CHE_MCP_TRANSPORT variable. ChangesDeployment environment configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Image built: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHE_MCP_MODE=fullto the deployment manifest so fresh deployments expose all 22 tools including terminal sessions andexec_in_workspaceorchestrationmode which hides terminal tools from all clientsContext
Per-client tool visibility is tracked in akurinnoy/agentic-workspaces#239. For now, all tools are exposed and access is constrained by agent protocol rules.
Summary by CodeRabbit