Add team_permissions support to repository#612
Open
WolfgangFischerEtas wants to merge 2 commits intoeclipse-csi:mainfrom
Open
Add team_permissions support to repository#612WolfgangFischerEtas wants to merge 2 commits intoeclipse-csi:mainfrom
WolfgangFischerEtas wants to merge 2 commits intoeclipse-csi:mainfrom
Conversation
Member
|
@WolfgangFischerEtas can you allow maintainers to edit the PR? |
Contributor
Unfortunately, we cannot do that. We have to use So “maintainers can fix the PR” is not possible in this setup. We can use whatever workaround you prefer, e.g.:
|
Member
|
ok I see, then I will test it out differently and provide my review comments. |
Member
|
I tested the PR and it works fine, a few small remarks to get this PR ready to be merged:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces first‑class support for managing GitHub team permissions directly within the Repository model in Otterdog. A new optional field has been added:
team_permissions: dict[str, str] | NonePurpose and Scope
The new team_permissions attribute allows repository configurations to define which teams should have which permission levels on a repository. This makes team–repository permission management a declarative part of the repository specification and aligns Otterdog more closely with GitHub’s permission model.
Behavior During Repository Creation and Updates
GitHub API Integration
Schema and JSONNET Output Enhancements
Example configuration entry as part of repository: