6044 Do not complete requests on receiving notification events#6086
Open
guerrillalg wants to merge 3 commits into
Open
6044 Do not complete requests on receiving notification events#6086guerrillalg wants to merge 3 commits into
guerrillalg wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix an issue #6044 in CompletedAsyncContextListener. Semantically speaking, this is supposed to be a listener. It is being notified about certain events when complete or error is already happening. It is essentially incorrect to complete the ongoing request at this moment. I propose to only update a flag, which is needed in related code.
Normally, a similar fix should be done in the 2.x as well, however I was not able to reproduce it using a test in that version. We can discuss on this and see how should we deal with it then.