Several small fixes#3763
Conversation
Removed the Confluent Kafka image and replaced it with the Apache Kafka image for integration tests. This change ensures that the tests are run against the latest version of Apache Kafka, which is more aligned with the project's requirements and dependencies.
Some of the integration tests are flaky in the CI environment. This commit increases the log level of the command router ni a few places to provide more insight to what is happening when the failing tests are executed.
| logger.info("received first message"); | ||
| firstMessageReceived.complete(); | ||
| break; | ||
| case "text/msg2": | ||
| logger.debug("received second message"); | ||
| logger.info("received second message"); |
There was a problem hiding this comment.
Those indentations aren't intentional, are they?
There was a problem hiding this comment.
Hmm, I am trying to use the Eclipse Formatter rules from the eclipse/ folder in my VS Code workspace. The change has been made automatically by the code formatter while I made changes to these lines. It seems like the formatter only applies the rules automatically on save to the changed lines, while it leaves the rest of the code untouched. This seems to have led to the wild mixture in indentation. When I format the whole file, almost all of the indentation is consistently changed.
I am afraid that many of the files in our repo do not really comply with our code formatting rules (yet).
IMHO we should strive to comply with these rules whenever we edit a file as part of a PR but should not apply the rules to all of the code base in one go.
Another option would be to adapt the code formatting rules accordingly, but I'd rather keep them as they are ...
WDYT?
2 participants
Adopt latest fixes from master branch to use Apache Kafka 4.3.1 container image for integration tests and temporarily increase log level for getting insight into reasons for flaky integration test failures.