Skip to content

Java 8#423

Open
gerring wants to merge 5 commits into
eclipse-january:masterfrom
gerring:java_8
Open

Java 8#423
gerring wants to merge 5 commits into
eclipse-january:masterfrom
gerring:java_8

Conversation

@gerring
Copy link
Copy Markdown
Contributor

@gerring gerring commented Feb 3, 2020

Move January to Java 8

#422

gerring
gerring commented Feb 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@gerring gerring left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method erasure change appears to be needed if using newer JDK with Java8 compliance. This can be turned off, however the code change to add a cast fixes the issue without developers having to change settings.

@gerring gerring requested a review from PeterC-DLS February 3, 2020 14:53
PeterC-DLS
PeterC-DLS reviewed Jan 21, 2022
View reviewed changes
Comment thread org.eclipse.january.examples/.classpath
Comment thread org.eclipse.january/src/org/eclipse/january/dataset/LazyDatasetBase.java Outdated
@PeterC-DLS
Copy link
Copy Markdown
Member

PeterC-DLS commented Feb 10, 2022

Thanks for the rebase. Any reason why some classpath files are deleted and others not updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gerring @PeterC-DLS