Print warning if adding parent folder of library to the classpath #4797#4817
Open
fedejeanne wants to merge 1 commit intoeclipse-jdt:masterfrom
Open
Conversation
Contributor
Author
|
@iloveeclipse I know you said you are busy in the next few weeks but maybe you could still make some time to take a look at this PR? It is pretty small and it merely adds a warning when some 3rd-party library does something risky like adding a parent folder to the classpath (which, as you said yourself in #4797 (comment), is a PITA). That way we could at least identify such bad libraries and handle them better. Thank you in advance! |
682f867 to
79e9d01
Compare
…ipse-jdt#4797 Print a warning in the trace log if the Class-Path entry in the manifest file of a third-party library includes a parent folder. This might not be forbidden but it's a dangerous practice. Contributes to: eclipse-jdt#4797
79e9d01 to
5fc4534
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Print a warning in the trace log if the Class-Path entry in the manifest file of a third-party library includes a parent folder. This might not be forbidden but it's a dangerous practice.
Contributes to: #4797
How to test
Expected
This should appear in the Console output:
Author checklist