[Formatter] Do not escape annotations inside snippet tags#4851
Merged
SougandhS merged 1 commit intoeclipse-jdt:masterfrom Mar 3, 2026
Merged
[Formatter] Do not escape annotations inside snippet tags#4851SougandhS merged 1 commit intoeclipse-jdt:masterfrom
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
Conversation
Member
Author
|
Hi @mateusz-matela, |
mateusz-matela
requested changes
Feb 25, 2026
Member
mateusz-matela
left a comment
There was a problem hiding this comment.
just one trivial suggestion, otherwise good to go!
24fc2b2 to
5c7aa38
Compare
5c7aa38 to
41eff42
Compare
mateusz-matela
approved these changes
Mar 1, 2026
41eff42 to
04cb408
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
562cc86 to
a55d31f
Compare
The formatter currently converts lines starting with '@' into '&eclipse-jdt#64;' inside snippet bodies. This commit prevents snippets to be marked as escape strings Fixes : eclipse-jdt#2071
a55d31f to
4697a08
Compare
Member
Author
|
Thanks @mateusz-matela ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatter currently converts lines starting with '@' into
inside snippet bodies. This commit prevents snippets to be marked as escape strings
Fixes : #2071
What it does
How to test
Author checklist