Skip to content

When completion is used to perform import, existing generics statement is ignored #4525#4863

Merged
jarthana merged 2 commits intoeclipse-jdt:masterfrom
jarthana:gh4525
Mar 3, 2026
Merged

When completion is used to perform import, existing generics statement is ignored #4525#4863
jarthana merged 2 commits intoeclipse-jdt:masterfrom
jarthana:gh4525

Conversation

@jarthana
Copy link
Copy Markdown
Member

@jarthana jarthana commented Feb 20, 2026

What it does

Fixes #4525

How to test

Author checklist

@jarthana jarthana added this to the 4.40 M1 milestone Mar 3, 2026
@jarthana jarthana self-assigned this Mar 3, 2026
@jarthana jarthana merged commit 07aabf2 into eclipse-jdt:master Mar 3, 2026
13 checks passed
@jarthana jarthana deleted the gh4525 branch March 3, 2026 09:05
@merks
Copy link
Copy Markdown
Contributor

merks commented Mar 4, 2026

@jarthana
// @iloveeclipse

I did a pull just now and I have errors in my workspace that I trace back to this PR:

image

I guess Collection should be more like this?

image

@merks
Copy link
Copy Markdown
Contributor

merks commented Mar 4, 2026

The errors are quite strange though. It makes me wonder if there is some classpath issue involved.

image

@jarthana
Copy link
Copy Markdown
Member Author

jarthana commented Mar 4, 2026

These classes are not supposed to be on workspace. Anyway, I am on it now. Will fix it in a bit.

@jarthana
Copy link
Copy Markdown
Member Author

jarthana commented Mar 4, 2026

The errors are quite strange though. It makes me wonder if there is some classpath issue involved.

I see the errors. I have no idea why they are reported. They go away on clean+build. So, might be the case of reconcile issue or something about system packages being used. Will raise a new ticket tomorrow for follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When completion is used to perform import, existing generics statement is ignored

2 participants