Refactor range and position utility methods for readability - #982
Open
Kaike-blanck wants to merge 1 commit into
Open
Refactor range and position utility methods for readability#982Kaike-blanck wants to merge 1 commit into
Kaike-blanck wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi LSP4J maintainers,
This PR refactors three small utility methods in Positions and Ranges to improve readability without changing behavior or public APIs.
The changes made are small and limited so as not to impact the functionality of the project.
The changes are limited to a few utility methods:
Positions.isBefore,Ranges.containsRange, andRanges.containsPosition. I simplified the condition inPositions.isBefore, added local variables inRanges.containsRange, and broke down the boolean expression inRanges.containsPositionso the logic of the method is a bit easier to follow.The inputs, expected return values, and expected behavior have not been altered. These changes do not introduce any API-level changes.