ci: enable aarch64 Linux build in CI matrix#28
Open
lh-sag wants to merge 6 commits intoinc/liebherrfrom
Open
Conversation
lh-sag
force-pushed
the
ci/enable-aarch64
branch
from
0c96d01 to
2029529
Compare
Author
|
This should fix some issues with outdated crates e.g. CI now passes and aarch64 is added for Linux too. |
Contributor
|
In general we can write PR message as: 1.Migrates from ring to aws-lc-rs for better support and security Rest all looks good to me. |
rama492
reviewed
Mar 19, 2026
| tokio = { workspace = true, features = ["macros", "rt"] } | ||
| http = { workspace = true } | ||
| rsa = { workspace = true } | ||
| aws-lc-rs = { workspace = true } |
Contributor
There was a problem hiding this comment.
do we also need version pinning like below? just that all crates are using same version.
Author
There was a problem hiding this comment.
We do, see Cargo.lock/toml in the toplevel directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add aarch64 Linux build in CI matrix
Checklist
Related
None
Notes for Reviewers
Testing CI.