docs: add diagnostic library component to design document#94
Open
docs: add diagnostic library component to design document#94
Conversation
Contributor
Author
|
Work in progress. Do not merge. |
stmuench
reviewed
Mar 17, 2026
There was a problem hiding this comment.
The IPC arrow from the App which contains fault-lib as well as diag-lib (upper left corner) should not overlay with the IPC arrow which originates from Configuration Manager since that might be misleading to readers.
stmuench
reviewed
Mar 17, 2026
docs/design/design.md
Outdated
|
|
||
| - Diagnostic Library | ||
| - Provides a framework agnostic interface for arbitrary apps and components to register and expose SOVD data resources. | ||
| - **The Diagnostic Library is the interface between S-CORE and the OpenSOVD project and should be developed in cooperation - see [ADR S-CORE Interface](./adr/001-adr-score-interface.md).** |
There was a problem hiding this comment.
Suggested change
| - **The Diagnostic Library is the interface between S-CORE and the OpenSOVD project and should be developed in cooperation - see [ADR S-CORE Interface](./adr/001-adr-score-interface.md).** | |
| - **The Diagnostic Library is also an interface between S-CORE and the OpenSOVD project and should be developed in cooperation - see [ADR S-CORE Interface](./adr/001-adr-score-interface.md).** |
There was a problem hiding this comment.
But here I would instead state that such API will be mandated by S-CORE. Otherwise, we will just run into conflicts later I fear.
Contributor
Author
|
Address PR comments and added example topology to illustrate it better. |
stmuench
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Related
None
Notes for Reviewers
None