Skip to content

[helm ci] Use helm repo for github action - #36

Merged
thjaeckle merged 3 commits into
eclipse-packages:masterfrom
kiwigrid:usehelmaction
Feb 10, 2020
Merged

[helm ci] Use helm repo for github action#36
thjaeckle merged 3 commits into
eclipse-packages:masterfrom
kiwigrid:usehelmaction

Conversation

@monotek

@monotek monotek commented Feb 7, 2020

Copy link
Copy Markdown
Contributor
  • Use helm repo for github action again as update kind to 0.7.0 helm/kind-action#16 has been merged
  • updated k8s versions
  • removed k8s 1.11 as storage class install fails there
  • fixes node image varname
  • added cluster version to step name …

Signed-off-by: André Bauer <monotek23@gmail.com>
Signed-off-by: André Bauer <monotek23@gmail.com>
Signed-off-by: André Bauer <monotek23@gmail.com>
@monotek
monotek requested review from calohmn and ctron as code owners February 7, 2020 15:18
@monotek
monotek requested a review from thjaeckle February 7, 2020 15:21
@ctron

ctron commented Feb 7, 2020

Copy link
Copy Markdown
Contributor

👍 from me … but is there anyone having concerns about removing Kubernetes 1.11?

@monotek

monotek commented Feb 7, 2020

Copy link
Copy Markdown
Contributor Author

from me … but is there anyone having concerns about removing Kubernetes 1.11?

I guess not because the initial plan about the pipeline was to start only with the 3 most recent ones :D

@sophokles73

Copy link
Copy Markdown
Contributor

@monotek @ctron FMPOV we should also remove at least Kubernetes 1.12 and I wouldn't have a problem with removing 1.13 as well ...

@monotek

monotek commented Feb 8, 2020

Copy link
Copy Markdown
Contributor Author

In gke 1.14 is not even the available default image so I'd like to wait with that ;-)

I've removed 1.11 just because there was some issue with kind.

I would even keep 1.12. The pipeline is not slower as all versions are tested in parallel.

Benefit would be to know if and when one of your releases become incompatible with a particular k8s version.

@sophokles73

Copy link
Copy Markdown
Contributor

@thjaeckle are you reviewing and merging this?

@thjaeckle

Copy link
Copy Markdown
Contributor

@thjaeckle are you reviewing and merging this?

@sophokles73 ok, will do

@thjaeckle thjaeckle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle
thjaeckle merged commit 56185fc into eclipse-packages:master Feb 10, 2020
nihadMaestral pushed a commit to nihadtz/packages that referenced this pull request Mar 3, 2023
[helm ci] Use helm repo for github action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants