Merged
Conversation
rpoet-jh
force-pushed
the
rdp-upgrade-deps
branch
from
f0ef1af to
d243c1a
Compare
Contributor
Author
|
@markpatton ok, this should be ready for review now. I had to disable the aws paramstore integration in tests explicitly to fix test failures. Something must have changed in GH runner, tests were passing locally. |
|
markpatton
approved these changes
Mar 12, 2026
Contributor
markpatton
left a comment
markpatton
left a comment
There was a problem hiding this comment.
Looks good. Ran tests locally as well.
Contributor
Author
@markpatton Thanks! Actually, there is this main PR too for upgrading the wfs eclipse-pass/main#1225. If you can review that PR too, I'd like to merge it before merging this one to test some of the updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrade pom dependencies and Dockerfiles.
Of note is oktthp was a major version upgrade. I changed the declaration by pulling okhttp into the pass-support root level pom DependencyManagement. This is so all modules in pass-support that use pass-data-client and okhttp can use the same version of okhttp.