[GTK4] Set source color when doing difference on pixels in Caret#2813
Closed
jonahgraham wants to merge 1 commit into
Closed
[GTK4] Set source color when doing difference on pixels in Caret#2813jonahgraham wants to merge 1 commit into
jonahgraham wants to merge 1 commit into
Conversation
Contributor
Member
|
Is this one still needed? |
With no source color explicitly set here, the difference is applied using whatever happens to have been the last set source color, or 0,0,0 if none have been set. See eclipse-platform#2812 (comment) for a longer explanation.
akurtakov
force-pushed
the
set-caret-source-color
branch
from
4b84b72 to
707e52b
Compare
Contributor
Member
|
I believe #3356 is a more complete fix than this PR. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no source color explicitly set here, the difference is applied using whatever happens to have been the last set source color, or 0,0,0 if none have been set.
See #2812 (comment) for a longer explanation.