[Win32] Remove unnecessary color disposal in GC

[HeikoKlare]

GC operations unnecessarily register stored colors for disposal, though colors do not need to be disposed anymore. This change removes the obsolete disposal tracking.

Contributes to #3296

[github-actions]

Test Results (win32)

   30 files  ±0     30 suites  ±0   4m 46s ⏱️ +2s
4 697 tests ±0  4 622 ✅ ±0  75 💤 ±0  0 ❌ ±0 
1 227 runs  ±0  1 203 ✅ ±0  24 💤 ±0  0 ❌ ±0 

Results for commit 168241f. ± Comparison against base commit 7f9089e.

[fedejeanne]

LGTM but just for my understanding: the reason we shouldn't dispose the Colors is because they are either system colors (which should live through the whole applications LC) or they are created outside of our control (in which case the creator should dispose them). Or did I get it wrong?

[iloveeclipse]

we shouldn't dispose the Colors is because they are either system colors (which should live through the whole applications LC) or they are created outside of our control

Colors don't need to be disposed at all anymore (independently of context), they are not system resources anymore after SWT changes.

[fedejeanne]

Indeed, thank you for the pointer!

• 359680f
• 9f2c5c8

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Color.java

Lines 24 to 26 in 823aeba

	* Colors do not need to be disposed, however to maintain compatibility
	* with older code, disposing a Color is not an error. As Colors do not require
	* disposal, the constructors which do not require a Device are recommended.