baselib: libmem migration#121
Draft
KrishaDeshkool wants to merge 22 commits intoeclipse-score:mainfrom
Draft
Conversation
score/memory has been moved to the communication repository with full git history preserved.
score/memory moved to communication repo and needs cross-repo visibility for this dependency.
score/memory moved to communication repo needs cross-repo visibility.
interprocess_notification is already public and depends on interprocess_mutex, so the mutex is effectively public already. Making it explicitly public to allow cross-repo access from score_communication after score/memory migration.
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
- Move atomic_indirector from memory/shared to concurrency/atomic - Move atomic_mock from memory/shared to concurrency/atomic - Move i_atomic interface from memory/shared to concurrency/atomic - Create dedicated atomic module in concurrency
- Remove exclusive_flock_mutex and related implementations - Remove shared_flock_mutex and related implementations - Remove flock_mutex and flock_mutex_and_lock implementations - Remove all tests for flock mutex variants
- Remove shared_memory_factory and related implementations - Remove i_shared_memory_factory interface - Remove lock_file utilities - Remove all tests for shared memory factory
- Remove shared_memory_resource and implementations - Remove shared_memory_resource test implementations - Remove all tests for shared memory resource - Remove shared_memory_test_resources utilities
- Remove sealedshm wrapper implementations and tests - Remove typedshm wrapper implementations and tests - Remove typedshm utilities module
- Remove my_bounded_shared_memory_resource implementation and tests - Remove new_delete_delegate_resource implementations - Remove managed_memory_resource_test - Remove memory_resource_proxy_test
- Remove split_string_view implementation and tests - Remove string_comparison_adaptor implementation and tests - Remove offset_ptr tests (bounds check, copying, arithmetic)
…actoring - Update includes in analysis/tracing modules - Update includes in language/safecpp safe_atomics - Update includes in json/internal/model - Update includes in mw/log modules - Update MODULE.bazel.lock - Update string_literal.h in memory - Update remaining references to moved/removed utilities
KrishaDeshkool
force-pushed
the
memory-removal
branch
from
3a23955 to
eae4c3f
Compare
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
- Add allocation_algorithm.cpp and allocation_algorithm.h - Move string utilities to dedicated score/string module
KrishaDeshkool
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
KrishaDeshkool
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
Required for score-communication to alias this target.
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
…ation - Delete all remaining files in score/memory/shared - Update BUILD deps in containers, analysis/tracing, language/safecpp to reference @score_communication//score/memory/shared instead - Update score/memory/BUILD to reference communication
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
Now that score/string/ has the actual implementations, remove the forwarding headers (string_literal.h, string_comparison_adaptor.h, split_string_view.h) and their cc_library targets from score/memory/BUILD. Also remove the @score_communication test suite reference.
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
- endianness, data_type_size_info, pmr_ring_buffer: add deprecation attribute telling consumers to switch to @score_communication//score/memory:* - score/memory/shared/BUILD: create forwarding alias targets with deprecation for all shared memory targets now in @score_communication - score/memory/shared/fake/BUILD: forwarding alias for fake_memory_resources - Update containers, tracing, safe_math BUILD refs to use local forwarding aliases (@score_baselibs//score/memory/shared:*) instead of direct @score_communication refs
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
…cated These are general-purpose memory utilities, not shared memory code. Keep them in baselibs with original visibility settings.
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
Add alias targets in score/memory/BUILD for string_literal, string_comparison_adaptor, split_string_view pointing to their new location in score/string/. Fix atomic alias targets in score/memory/shared/BUILD to point to score/concurrency/atomic/ instead of @score_communication.
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
Add deprecation aliases for targets that were present in upstream but missing from the forwarding BUILD: - lock_file, shared_memory_resource, i_shared_memory_factory - shared_memory_factory, shared_memory_factory_impl, shared_memory_factory_mock - shared, new_delete_delegate_resource, shared_memory_test_resources - shared_memory_resource_heap_allocator_mock, shared_memory_resource_mock - my_bounded_shared_memory_resource (in fake/)
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
KrishaDeshkool
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.