containers: add ScoreDebug and Debug#83
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
There was a problem hiding this comment.
Pull request overview
Adds ScoreDebug (and missing Debug) implementations across the containers crate to support SCORE logging-format debug output and improve debuggability of container types (per Issue #82).
Changes:
- Implement
score_log::fmt::ScoreDebugfor multiple inline, generic, and fixed-capacity container types. - Add/adjust
core::fmt::Debugimplementations where missing (notably queues). - Wire in
score_logas a dependency (Cargo + Bazel), updating lockfile accordingly.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/containers/inline/vec.rs | Add ScoreDebug for InlineVec by delegating to slice formatting. |
| src/containers/inline/string.rs | Add ScoreDebug for InlineString by delegating to str. |
| src/containers/inline/result.rs | Add ScoreDebug for InlineResult (currently delegates to Result<&T,&E>). |
| src/containers/inline/queue.rs | Add Debug + ScoreDebug for InlineQueue delegating to inner queue. |
| src/containers/inline/option.rs | Add ScoreDebug for InlineOption delegating to Option<&T>. |
| src/containers/generic/vec.rs | Add ScoreDebug for GenericVec delegating to slice formatting. |
| src/containers/generic/string.rs | Add ScoreDebug for GenericString delegating to str. |
| src/containers/generic/queue.rs | Add Debug + ScoreDebug for GenericQueue using list-style formatting. |
| src/containers/fixed_capacity/vec.rs | Add ScoreDebug for fixed-capacity vectors (both In and wrapper). |
| src/containers/fixed_capacity/string.rs | Add ScoreDebug for fixed-capacity strings (and adjust Debug delegation). |
| src/containers/fixed_capacity/queue.rs | Add Debug + ScoreDebug for FixedCapacityQueueIn. |
| src/containers/Cargo.toml | Add score_log workspace dependency. |
| src/containers/BUILD | Add Bazel dependency on //src/log/score_log. |
| Cargo.lock | Record new score_log dependency in lockfile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
78bea98 to
ce371bc
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add `ScoreDebug` and `Debug` implementations.
ce371bc to
544c1af
Compare
pawelrutkaq
left a comment
There was a problem hiding this comment.
wonder if we can remove boilerplate impls which jsut call one liners?
- Remove gated features. - Remove `no_std` from containers.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add
ScoreDebugandDebugimplementations.Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #82