Skip to content

lola: Performance improvements for Service/Event[Data]Control #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bemerybmw wants to merge 3 commits into
base: main
Choose a base branch
from
+3,737 −3,089
Draft

lola: Performance improvements for Service/Event[Data]Control #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3743e10
lola: Add Service/Event/EventData Control Local structs
bemerybmw Mar 12, 2026
5916053
lola: Pass reference to EventDataControlComposite
bemerybmw Mar 17, 2026
5dc4dba
Remove ControlSlotIndicator and ControlSlotCompositeIndicator
bemerybmw Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 142 additions & 56 deletions score/mw/com/impl/bindings/lola/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ cc_library(
":application_id_pid_mapping",
":element_fq_id",
":event_control",
":event_meta_info",
"@score_baselibs//score/memory/shared",
],
)
Expand Down Expand Up @@ -264,6 +263,33 @@ cc_library(
],
)

cc_library(
name = "skeleton_service_data_control_local_view",
srcs = ["skeleton_service_data_control_local_view.cpp"],
hdrs = ["skeleton_service_data_control_local_view.h"],
features = COMPILER_WARNING_FEATURES,
tags = ["FFI"],
deps = [
":element_fq_id",
":service_data_control",
":skeleton_event_control_local_view",
],
)

cc_library(
name = "proxy_service_data_control_local_view",
srcs = ["proxy_service_data_control_local_view.cpp"],
hdrs = ["proxy_service_data_control_local_view.h"],
features = COMPILER_WARNING_FEATURES,
tags = ["FFI"],
deps = [
":application_id_pid_mapping",
":element_fq_id",
":proxy_event_control_local_view",
":service_data_control",
],
)

cc_library(
name = "skeleton",
srcs = [
Expand Down Expand Up @@ -292,10 +318,12 @@ cc_library(
":i_shm_path_builder",
":partial_restart_path_builder",
":proxy_instance_identifier",
":proxy_service_data_control_local_view",
":service_data_control",
":service_data_storage",
":shm_path_builder",
":skeleton_instance_identifier",
":skeleton_service_data_control_local_view",
":transaction_log_registration_guard",
":type_erased_sample_ptrs_guard",
"//score/mw/com/impl:error",
Expand Down Expand Up @@ -350,7 +378,9 @@ cc_library(
":event",
":event_control",
":event_subscription_control",
":proxy_event_control_local_view",
":proxy_instance_identifier",
":proxy_service_data_control_local_view",
":service_data_control",
":service_data_storage",
":shm_path_builder",
Expand Down Expand Up @@ -420,7 +450,7 @@ cc_library(
"//score/mw/com/impl:__subpackages__",
],
deps = [
":event_data_control",
":proxy_event_data_control_local_view",
":slot_decrementer",
],
)
Expand All @@ -435,7 +465,7 @@ cc_library(
"//score/mw/com/impl:__subpackages__",
],
deps = [
":event_data_control",
":proxy_event_data_control_local_view",
":transaction_log_set",
],
)
Expand Down Expand Up @@ -463,9 +493,9 @@ cc_library(
features = COMPILER_WARNING_FEATURES,
tags = ["FFI"],
deps = [
":event_control",
":event_data_control",
":i_runtime",
":proxy_event_control_local_view",
":proxy_event_data_control_local_view",
":slot_collector",
":transaction_log_id",
":transaction_log_registration_guard",
Expand All @@ -482,8 +512,8 @@ cc_library(
features = COMPILER_WARNING_FEATURES,
tags = ["FFI"],
deps = [
":event_data_control",
":event_slot_status",
":proxy_event_data_control_local_view",
":transaction_log_set",
],
)
Expand Down Expand Up @@ -530,42 +560,53 @@ cc_library(
)

cc_library(
name = "control_slot_indicator",
srcs = [
"control_slot_composite_indicator.cpp",
"control_slot_indicator.cpp",
],
hdrs = [
"control_slot_composite_indicator.h",
"control_slot_indicator.h",
name = "event_data_control",
srcs = ["event_data_control.cpp"],
hdrs = ["event_data_control.h"],
features = COMPILER_WARNING_FEATURES,
tags = ["FFI"],
visibility = ["//score/mw/com/impl/bindings/lola:__subpackages__"],
deps = [
":control_slot_types",
":event_slot_status",
":transaction_log",
":transaction_log_id",
":transaction_log_set",
"@score_baselibs//score/containers:dynamic_array",
"@score_baselibs//score/memory/shared:atomic_indirector",
"@score_baselibs//score/memory/shared:types",
],
)

cc_library(
name = "skeleton_event_data_control_local_view",
srcs = ["skeleton_event_data_control_local_view.cpp"],
hdrs = ["skeleton_event_data_control_local_view.h"],
features = COMPILER_WARNING_FEATURES,
tags = ["FFI"],
visibility = ["//score/mw/com/impl/bindings/lola:__subpackages__"],
deps = [
":control_slot_types",
":event_data_control",
":event_slot_status",
"@score_baselibs//score/language/futurecpp",
":transaction_log_set",
"@score_baselibs//score/memory/shared:atomic_indirector",
],
)

cc_library(
name = "event_data_control",
srcs = ["event_data_control.cpp"],
hdrs = ["event_data_control.h"],
name = "proxy_event_data_control_local_view",
srcs = ["proxy_event_data_control_local_view.cpp"],
hdrs = ["proxy_event_data_control_local_view.h"],
features = COMPILER_WARNING_FEATURES,
tags = ["FFI"],
visibility = ["//score/mw/com/impl/bindings/lola:__subpackages__"],
deps = [
":control_slot_indicator",
":control_slot_types",
":event_data_control",
":event_slot_status",
":transaction_log",
":transaction_log_id",
":transaction_log_set",
"@score_baselibs//score/containers:dynamic_array",
"@score_baselibs//score/memory/shared:atomic_indirector",
"@score_baselibs//score/memory/shared:types",
],
)

Expand Down Expand Up @@ -597,6 +638,33 @@ cc_library(
],
)

cc_library(
name = "skeleton_event_control_local_view",
srcs = ["skeleton_event_control_local_view.cpp"],
hdrs = ["skeleton_event_control_local_view.h"],
features = COMPILER_WARNING_FEATURES,
tags = ["FFI"],
visibility = ["//score/mw/com/impl/bindings/lola:__subpackages__"],
deps = [
":event_control",
":skeleton_event_data_control_local_view",
],
)

cc_library(
name = "proxy_event_control_local_view",
srcs = ["proxy_event_control_local_view.cpp"],
hdrs = ["proxy_event_control_local_view.h"],
features = COMPILER_WARNING_FEATURES,
tags = ["FFI"],
visibility = ["//score/mw/com/impl/bindings/lola:__subpackages__"],
deps = [
":event_control",
":event_data_control",
":proxy_event_data_control_local_view",
],
)

cc_library(
name = "event_subscription_control",
srcs = ["event_subscription_control.cpp"],
Expand Down Expand Up @@ -638,6 +706,8 @@ cc_library(
":control_slot_types",
":event_data_control",
":event_slot_status",
":proxy_event_data_control_local_view",
":skeleton_event_data_control_local_view",
"@score_baselibs//score/memory/shared:atomic_indirector",
],
)
Expand Down Expand Up @@ -751,7 +821,7 @@ cc_library(
tags = ["FFI"],
visibility = ["//score/mw/com/impl/bindings/lola:__subpackages__"],
deps = [
":service_data_control",
":proxy_service_data_control_local_view",
":transaction_log_id",
":transaction_log_set",
"//score/mw/com/impl:runtime",
Expand All @@ -773,8 +843,10 @@ cc_library(
tags = ["FFI"],
visibility = ["//score/mw/com/impl/bindings/lola:__subpackages__"],
deps = [
":event_data_control",
":proxy_event_data_control_local_view",
":skeleton_event_data_control_local_view",
":transaction_log_id",
":transaction_log_set",
"@score_baselibs//score/result",
],
)
Expand Down Expand Up @@ -943,28 +1015,58 @@ cc_unit_test(
],
)

cc_test(
cc_gtest_unit_test(
name = "event_data_control_test",
srcs = ["event_data_control_test.cpp"],
features = COMPILER_WARNING_FEATURES,
deps = [
":event_data_control",
":event_slot_status",
"@score_baselibs//score/containers:dynamic_array",
],
)

cc_test(
name = "skeleton_event_data_control_local_view_test",
size = "small",
timeout = "long",
srcs = [
"event_data_control_test.cpp",
"skeleton_event_data_control_local_view_test.cpp",
],
features = COMPILER_WARNING_FEATURES + [
"aborts_upon_exception",
],
tags = ["unit"],
deps = [
"//score/mw/com/impl:instance_specifier",
":skeleton_event_data_control_local_view",
"//score/mw/com/impl/bindings/lola:event_data_control",
"//score/mw/com/impl/bindings/lola:event_slot_status",
"//score/mw/com/impl/bindings/lola/test_doubles:fake_memory_resource",
"@googletest//:gtest_main",
"@score_baselibs//score/language/safecpp/coverage_termination_handler",
"@score_baselibs//score/memory/shared:atomic_indirector_mock_binding",
],
)

cc_test(
name = "proxy_event_data_control_local_view_test",
size = "small",
timeout = "long",
srcs = [
"proxy_event_data_control_local_view_test.cpp",
],
features = COMPILER_WARNING_FEATURES + [
"aborts_upon_exception",
],
tags = ["unit"],
deps = [
":proxy_event_data_control_local_view",
":skeleton_event_data_control_local_view",
"//score/mw/com/impl/bindings/lola:event_data_control",
"//score/mw/com/impl/bindings/lola:event_data_control_composite",
"//score/mw/com/impl/bindings/lola/test_doubles:fake_memory_resource",
"@googletest//:gtest_main",
"@score_baselibs//score/containers:dynamic_array",
"@score_baselibs//score/language/futurecpp",
"@score_baselibs//score/language/safecpp/coverage_termination_handler",
"@score_baselibs//score/memory/shared:atomic_indirector_mock_binding",
"@score_baselibs//score/memory/shared:new_delete_delegate_resource",
],
)

Expand All @@ -973,6 +1075,8 @@ cc_gtest_unit_test(
srcs = ["event_data_control_composite_test.cpp"],
features = COMPILER_WARNING_FEATURES,
deps = [
":proxy_event_data_control_local_view",
":skeleton_event_data_control_local_view",
"//score/mw/com/impl:instance_specifier",
"//score/mw/com/impl/bindings/lola:event_data_control",
"//score/mw/com/impl/bindings/lola:event_data_control_composite",
Expand Down Expand Up @@ -1082,6 +1186,8 @@ cc_gtest_unit_test(
features = COMPILER_WARNING_FEATURES,
deps = [
":event_data_control",
":proxy_event_data_control_local_view",
":skeleton_event_data_control_local_view",
":slot_decrementer",
"//score/mw/com/impl/bindings/lola/test_doubles:fake_memory_resource",
],
Expand All @@ -1105,28 +1211,6 @@ cc_gtest_unit_test(
],
)

cc_gtest_unit_test(
name = "control_slot_composite_indicator_test",
srcs = [
"control_slot_composite_indicator_test.cpp",
],
features = COMPILER_WARNING_FEATURES,
deps = [
":control_slot_indicator",
],
)

cc_gtest_unit_test(
name = "control_slot_indicator_test",
srcs = [
"control_slot_indicator_test.cpp",
],
features = COMPILER_WARNING_FEATURES,
deps = [
":control_slot_indicator",
],
)

cc_gtest_unit_test(
name = "element_fq_id_test",
srcs = [
Expand Down Expand Up @@ -1275,6 +1359,8 @@ cc_gtest_unit_test(
],
features = COMPILER_WARNING_FEATURES,
deps = [
":proxy_event_data_control_local_view",
":skeleton_event_data_control_local_view",
":slot_collector",
"//score/mw/com/impl/bindings/lola/test_doubles",
],
Expand Down Expand Up @@ -1421,8 +1507,6 @@ cc_unit_test(
cc_unit_test_suites_for_host_and_qnx(
name = "unit_test_suite",
cc_unit_tests = [
":control_slot_composite_indicator_test",
":control_slot_indicator_test",
":element_fq_id_test",
":event_data_storage_test",
":event_slot_status_test",
Expand All @@ -1447,6 +1531,8 @@ cc_unit_test_suites_for_host_and_qnx(
":dynamic_array_bounds_checking_test",
":event_data_control_test",
":event_data_control_composite_test",
":proxy_event_data_control_local_view_test",
":skeleton_event_data_control_local_view_test",
":generic_proxy_event_test",
":partial_restart_path_builder_test",
":proxy_instance_identifier_test",
Expand Down
Loading
Loading