score/com: lib memory shared migration phase 1#246
Open
KrishaDeshkool wants to merge 6 commits intoeclipse-score:mainfrom
Open
score/com: lib memory shared migration phase 1#246KrishaDeshkool wants to merge 6 commits intoeclipse-score:mainfrom
KrishaDeshkool wants to merge 6 commits intoeclipse-score:mainfrom
Conversation
KrishaDeshkool
force-pushed
the
memory-migration-v2
branch
6 times, most recently
from
6f7f39d to
13d80dc
Compare
KrishaDeshkool
commented
Mar 27, 2026
KrishaDeshkool
force-pushed
the
memory-migration-v2
branch
2 times, most recently
from
aeb6cc6 to
6195c55
Compare
Contributor
Author
|
This PR links against the baselibs PR hash that has the changes this PR needs, |
KrishaDeshkool
changed the title
KrishaDeshkool
changed the title
KrishaDeshkool
force-pushed
the
memory-migration-v2
branch
4 times, most recently
from
093d2f3 to
18813e6
Compare
Add boost.container to MODULE.bazel deps required by the local score/memory library. Configure .bazelrc to use the local baselibs checkout as an override so the in-tree score/memory sources are resolved instead of the registry copy.
Add the score/memory shared-memory library sources, headers, tests, and design documentation copied from the baselibs repository. This brings the library in-tree so communication can depend on it directly without an external Bazel module reference.
Define cc_library, cc_test, and related Bazel targets for the score/memory shared-memory library that was copied in-tree. All targets use the repo-local label //score/memory/... rather than the external @score_baselibs//score/memory/...
Replace all @score_baselibs//score/memory/... dependency labels in score/mw/com BUILD files with the in-tree //score/memory/... equivalents now that the library has been copied locally.
Update #include paths and namespace references in score/mw/com sources to reflect that AtomicIndirector and related types are now accessed via concurrency::atomic:: rather than memory::shared:: following the in-tree copy of the score/memory library.
Primitive targets (offset_ptr, managed_memory_resource, vector, map, string, etc.) are aliases to baselibs — their tests belong in baselibs not here. Having test source files compiled locally against aliased headers causes toolchain mismatches (e.g. string_test fails with tsan/clang because the header comes from baselibs compiled with gcc). Removed 13 test targets and source files. Kept only tests for heavy targets that communication owns (factory, resource, lock_file, etc.).
KrishaDeshkool
force-pushed
the
memory-migration-v2
branch
from
18813e6 to
23dfc4a
Compare
KrishaDeshkool
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.