Improve connection timeout handling for SmtpConnectionPool#1986
Closed
matthiaso wants to merge 1 commit intoreleases/24.2from
Closed
Improve connection timeout handling for SmtpConnectionPool#1986matthiaso wants to merge 1 commit intoreleases/24.2from
matthiaso wants to merge 1 commit intoreleases/24.2from
Conversation
matthiaso
force-pushed
the
features/matthiaso/24.2/improveConnectionTimeoutForSmtpConnectionPool
branch
from
e4d0142 to
674fc47
Compare
paolobazzi
reviewed
Feb 11, 2026
| @Override | ||
| public Integer getDefaultValue() { | ||
| return 60; // 1 minute | ||
| return 20; // 20 seconds |
Member
There was a problem hiding this comment.
Consider change the default value only for major release (e.g. 26/1)?
Member
Author
There was a problem hiding this comment.
Maybe whole improvement only for 26/1 or 26/2?
Member
Author
There was a problem hiding this comment.
New target release is 26/1 (for whole change for now)
| public static class CloseIdleConnectionsJobScheduleProperty extends AbstractPositiveIntegerConfigProperty { | ||
| @Override | ||
| public Integer getDefaultValue() { | ||
| return 20; // 20 seconds |
Member
There was a problem hiding this comment.
Consider change the default value only for major release (e.g. 26/1)?
Member
Author
There was a problem hiding this comment.
New target release is 26/1 (for whole change for now)
org.eclipse.scout.rt.mail/src/main/java/org/eclipse/scout/rt/mail/smtp/SmtpConnectionPool.java
Show resolved
Hide resolved
org.eclipse.scout.rt.mail/src/main/java/org/eclipse/scout/rt/mail/smtp/SmtpConnectionPool.java
Show resolved
Hide resolved
matthiaso
force-pushed
the
features/matthiaso/24.2/improveConnectionTimeoutForSmtpConnectionPool
branch
from
674fc47 to
8a8c187
Compare
* Decrease default timeouts from 1 minute to 20 seconds * RFC-conformity: Connection failures should be treated the same way 451 errors are treated (hence treat 451 errors the same way connection failures are already treated) 434975
matthiaso
force-pushed
the
features/matthiaso/24.2/improveConnectionTimeoutForSmtpConnectionPool
branch
from
8a8c187 to
ad9e3e8
Compare
Member
Author
|
Replaced by #2014 |
matthiaso
deleted the
features/matthiaso/24.2/improveConnectionTimeoutForSmtpConnectionPool
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
434975