Add support for zero and negative value indexing in BinaryIndexers#566
Open
Add support for zero and negative value indexing in BinaryIndexers#566
Conversation
…naryIndexers. - Introduced sentinel values to handle zero for all numerical indexers (Byte, Short, Integer, Long, Float, Double). - Updated tests to validate zero and negative value handling. - Added strict validation and sentinel logic for `Long.MAX_VALUE` as a reserved key. - Adjusted BinaryUUIDIndex test cases to include scenarios with zero components in UUIDs. - Simplified structure of test cases to improve readability and maintainability.
… values in BinaryIndexer tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed
Long.MAX_VALUE.Why are these changes relevant?
These updates bridge a gap in numerical indexing handling and improve test coverage with the ability to manage zero and negative values effectively.
Other notes
No changes made to unrelated components.
Consistency ensured across all supported numerical types.