Fix FileInputStream leak in ComponentDatabaseHandler (#3965)#3967
Open
PDGGK wants to merge 1 commit intoeclipse-sw360:mainfrom
Open
Fix FileInputStream leak in ComponentDatabaseHandler (#3965)#3967PDGGK wants to merge 1 commit intoeclipse-sw360:mainfrom
PDGGK wants to merge 1 commit intoeclipse-sw360:mainfrom
Conversation
PDGGK
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
GMishx
added
needs code review
needs general test
PDGGK
force-pushed
the
fix/sw360-3965-fileinputstream-leak
branch
from
06acbcc to
05c537b
Compare
…ler (eclipse-sw360#3965) Signed-off-by: ffccites <99155080+PDGGK@users.noreply.github.com>
PDGGK
force-pushed
the
fix/sw360-3965-fileinputstream-leak
branch
from
05c537b to
db084b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unclosed FileInputStream in
uploadAttachment()method.Closes #3965
Changes
ComponentDatabaseHandler.java: WrappedFileInputStreamin try-with-resources inuploadAttachment(). The stream was previously created and passed touploadAttachmentContent()without ever being closed.