Fix resource leak in SVMUtils (#3964)#3968
Closed
PDGGK wants to merge 1 commit intoeclipse-sw360:mainfrom
Closed
Conversation
PDGGK
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
GMishx
added
needs code review
needs general test
PDGGK
force-pushed
the
fix/sw360-3964-svmutils-leak
branch
from
b063e08 to
360c932
Compare
Signed-off-by: ffccites <99155080+PDGGK@users.noreply.github.com>
PDGGK
force-pushed
the
fix/sw360-3964-svmutils-leak
branch
from
360c932 to
8e09cd4
Compare
Contributor
|
LGTM. Please sign the Eclipse Contributor Agreement (ECA) before this PR can be merged. |
rudra-superrr
added
has merge conflicts
Member
|
Closing in favor of #4079 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes unclosed BufferedReader and missing HttpURLConnection.disconnect() in prepareJSONRequestAndGetResponse(). Wrapped readers in try-with-resources and added finally block for disconnect. Closes #3964