fix(components): add missing user validation in ComponentHandler#3972
Open
mahmoud-40 wants to merge 2 commits intoeclipse-sw360:mainfrom
Open
fix(components): add missing user validation in ComponentHandler#3972mahmoud-40 wants to merge 2 commits intoeclipse-sw360:mainfrom
mahmoud-40 wants to merge 2 commits intoeclipse-sw360:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing user validation to methods in
ComponentHandler.javathat accepted aUserparameter without validating it before delegating to the database handler layer, allowing null or malformed users to propagate silently into the database handler.Suggest Reviewer
@GMishx @amritkv @rudra-superrr @bibhuti230185
How To Test?
The fix is a defensive validation addition with no business logic changes. To verify:
Usernow fails fast with a clear validation error rather than propagating into the handler layer.Affected methods:
assertUser(user):getRecentReleasesWithAccessibility,getReleaseIdsFromComponentId,getAccessibleReleasesFromVendorIds,getUsingComponentsWithAccessibilityForRelease,getUsingComponentsWithAccessibilityForComponent,getRecentComponentsSummaryWithPagination,refineSearchWithAccessibility,getAccessibleRecentComponentsSummary,searchAccessibleReleasesCollections.emptyMap():refineSearchAccessibleComponents,searchComponentByNamePrefixPaginated,searchComponentByExactNamePaginatedthese declare nothrowsclause soassertUsercannot be used directly.No additional tests implemented; the change is purely defensive input validation consistent with the existing pattern throughout the class.
Checklist
Must: